On Tue, Mar 27 2012, Jani Nikula <jani at nikula.org> wrote: > v3 of id:"cover.1332702915.git.jani at nikula.org" with the following > mostly non-functional changes: > > - add test for the current tagging behaviour in patch 1, and change the > test in patch 2 when the behaviour is changed > - handle the no tag changes case in _optimize_tag_query() in patch 2 > - add braces around the "tag_ops[tag_ops_count].remove = (argv[i][0] == > '-');" > assignment > - document the tag_query() function a bit in patch 3 > - make tag_message() static in patch 4
LGTM. > > BR, > Jani. Tomi > > > Jani Nikula (4): > test: add test for both adding and removing a tag at the same time > cli: refactor "notmuch tag" data structures for tagging operations > cli: refactor "notmuch tag" query tagging into a separate function > cli: refactor "notmuch restore" message tagging into a separate > function > > notmuch-restore.c | 148 ++++++++++++++++++++++++--------------------- > notmuch-tag.c | 173 > ++++++++++++++++++++++++++++------------------------- > test/tagging | 8 +++ > 3 files changed, 178 insertions(+), 151 deletions(-) > > -- > 1.7.5.4 > > _______________________________________________ > notmuch mailing list > notmuch at notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch
