On Tue, 17 Apr 2012 13:06:13 +0400, Dmitry Kurochkin <dmitry.kurochkin at gmail.com> wrote: > Can you please give some explanaition why is this needed? Would this > change break custom hooks that do not expect any arguments?
For patch 3/4. We don't want to display a message if someone calls (notmuch-hello-update t) from some script, and notmuch-hello buffer isn't even visible. Yes, it would break custom hooks. And a bunch of tests. But I think it would be useful for custom hooks too, for the same reason as above. Jani. > > Regards, > Dmitry > > Jani Nikula <jani at nikula.org> writes: > > > --- > > emacs/notmuch-hello.el | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el > > index 9cd907a..0596bbe 100644 > > --- a/emacs/notmuch-hello.el > > +++ b/emacs/notmuch-hello.el > > @@ -776,7 +776,7 @@ following: > > (widget-setup) > > > > (goto-char final-target-pos)) > > - (run-hooks 'notmuch-hello-refresh-hook) > > + (run-hook-with-args 'notmuch-hello-refresh-hook no-display) > > (setq notmuch-hello-first-run nil)) > > > > (defun notmuch-folder () > > -- > > 1.7.1 > > > > _______________________________________________ > > notmuch mailing list > > notmuch at notmuchmail.org > > http://notmuchmail.org/mailman/listinfo/notmuch