LGTM. While I thought --stderr was a fine solution originally, now that we've stumbled across problems that make it difficult to use correctly and robustly, I think Tomi's right that we should probably revert it.
On Fri, 31 May 2013, Tomi Ollila <tomi.ollila at iki.fi> wrote: > While looked good on paper, its attempted use caused confusion, complexity, > and potential for information leak when passed through wrapper scripts. > For slimmer code and to lessen demand for maintenance/support the set of > commits which added top level --stderr= option is now reverted. > --- > > Change was easy, commit message hard. Opinions? Revert is easiest to do now. > Also, if someone comes with a novel idea how to utilize --stderr option > please tell it now -- I'd be most eager to hear it :D > > > This change was done the following way: > > $ git checkout -b rvrt b9020448bd > $ git reset --hard HEAD^^^^ > $ git reset b9020448bd > $ git commit -a > $ git diff HEAD~5..HEAD > > (last one to reveal HEAD~5 & HEAD have identical trees). > > Question why: > id:20130521195549.6550.53636 at thinkbox.jade-hamburg.de > > Good reason why not: > id:1369934016-22308-1-git-send-email-amdragon at mit.edu