On Fri, Aug 16 2013, Istvan Marko <notmuch at kismala.com> wrote: > When text/html parts include images as multipart/related and the > text/plain alternative is used these images can be completely hidden > with no easy way to access them or even find out that they are there. > > Make notmuch-show-insert-part-multipart/related add buttons for all > parts, the first one visible the rest hidden.
Hey, Istvan. Thanks so much for this patch. It seems to be addressing the same issue I reported in id:87ob8u8l6k.fsf at servo.finestructure.net. However, the behavior of the part button that now appears seems to be a bit strange. Clicking/hitting enter on the part attempts to save it rather than open it. I wouldn't be surprised if has nothing to do with the correctness of this patch, though. So is it possible that the button is not inserted in the most ideal way, or is there some other issue preventing it from behaving properly (could it have to do with the part being "inline"?)? jamie. > emacs/notmuch-show.el | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el > index 82b70ba..20844f0 100644 > --- a/emacs/notmuch-show.el > +++ b/emacs/notmuch-show.el > @@ -621,6 +621,10 @@ message at DEPTH in the current thread." > > ;; Render the primary part. > (notmuch-show-insert-bodypart msg (car inner-parts) depth) > + ;; Add hidden buttons for the rest > + (mapc (lambda (inner-part) > + (notmuch-show-insert-bodypart msg inner-part depth t)) > + (cdr inner-parts)) > > (when notmuch-show-indent-multipart > (indent-rigidly start (point) 1))) > -- > 1.8.1.4 -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20130820/5d18b5e8/attachment.pgp>
