On Sun, 18 Aug 2013, Tomi Ollila <tomi.ollila at iki.fi> wrote: > Now, if we have --include-html should it be like that or > --include-html=(true|false). Currently we have both cases, adding > --verify, --decrypt, --create-folder, --batch, -no-hooks to the > set... I cannot get a clear opinion (without wast^H^H^H^H spending > excessive amount of time figuring these out) how this should be, > therefore I'm inclined to the opinion that > > the current patch from John with simple --include-html could be applied, > and in the future (if it is of anyone's interest) we update the parser > allowing boolean --arg equal --arg=true. Then it is just how we decide > to document these...
The argument parser we have allows NOTMUCH_OPT_BOOLEAN options to be specified as --foo=(true|false) or simply --foo (for true). It is already now just a matter of documentation, and I'm sure we're not consistent. We also have things like --no-hooks in notmuch new. I added that, and in retrospect, that should be just --hooks=(true|false). I guess we left it like that because the default is true. Perhaps we should amend the argument parser to look for boolean option --foo if it encounters a --no-foo option. Why notmuch show has --exclude=(true|false) as a keyword option I don't quite grasp; the --entire-thread option at least has a special default. It might help some options if the parser had a way to tell if it's seen some option or not. Of course, none of this is really relevant to the patch in question! BR, Jani.
