On Mon, 19 Aug 2013, Tomi Ollila <tomi.ollila at iki.fi> wrote: > On Fri, Aug 09 2013, Tomi Ollila <tomi.ollila at iki.fi> wrote: > >> On Thu, Aug 08 2013, Geoffrey Ferrari <geoffrey.ferrari at oriel.oxon.org> >> wrote: >> >>> From: "Geoffrey H. Ferrari" <geoffrey.ferrari at oriel.oxon.org> >>> >>> When composing a reply, notmuch-mua-reply tries to be smart and cite >>> the original message by inserting it before the user signature, if >>> one is present. However, the existing method of backward searching >>> from the end of the buffer to find the signature separator and then >>> moving one line up results in the original message being cited in >>> the message headers. That's because at this point the message looks >>> like this (with | representing point after searching for the >>> signature separator): >>> >>> From: xxx >>> To: xxx >>> Subject: xxx >>> --text follows this line-- >>> |-- >>> My fancy signature >>> >>> With this patch, a newline is opened instead, so that the orignal >>> message is cited above the signature but still in the message text. >>> --- >> >> This probably fixes #1 in id:8762auwgfl.fsf at steelpick.2x.cz >> >> ( http://mid.gmane.org/8762auwgfl.fsf at steelpick.2x.cz ) >> >> ... I just noticed I have no clue how to set message signature to test >> this... ;/ > > Now I tried something fancy and executed `echo foobar > ~/.signature` > > Now I get the "--\nfoobar" at the end of all emails I'm, composing -- but > I don't see any problems when replying... so I'd be interested to see > in what circumstances could I get the problem this patch solves exposed.
Hi Geoffrey, we can't reproduce the issue this patch claims to fix. Care to provide more info please? BR, Jani. > >> >> Tomi > > Tomi > > >> >> >> >>> emacs/notmuch-mua.el | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el >>> index 2baae5f..86f164d 100644 >>> --- a/emacs/notmuch-mua.el >>> +++ b/emacs/notmuch-mua.el >>> @@ -194,7 +194,7 @@ list." >>> ;; if one is present >>> (goto-char (point-max)) >>> (if (re-search-backward message-signature-separator nil t) >>> - (forward-line -1) >>> + (newline) >>> (goto-char (point-max))) >>> >>> (let ((from (plist-get original-headers :From)) >>> -- >>> 1.7.10.4 >>> >>> _______________________________________________ >>> notmuch mailing list >>> notmuch at notmuchmail.org >>> http://notmuchmail.org/mailman/listinfo/notmuch > _______________________________________________ > notmuch mailing list > notmuch at notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch
