On Fri, May 09 2014, Mark Walters wrote: > The first two patches are fine, although I think I like constructing a > query then quoting rather than quoting bits of a query and bolting them > together (even the both work).
Agreed. I've no idea what I was thinking. > My concern is that the current approach gives the user no warning if > they are about to overwrite an existing file, and that this is true > regardless of any emacs settings. > > Could we do these saves by loading into a temporary buffer and then > using the normal emacs save buffer functions? That way we get the > benefit of emacs's normal query-overwrite, and respect any user > customizations of that. Yes, that is a better approach. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 310 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20140509/c9427931/attachment.pgp>
