On Mon, May 12 2014, Mark Walters wrote: >>> Secondly, the existing code only includes text sub-parts of the >>> message. I would think your version might include any sub-parts show is >>> configured to display, including, say images. (However, in my testing >>> images didn't seem to be included: I am not sure why.) >> >> Eek. > > I phrased this badly. I don't want images included: I just couldn't see > why they weren't with your current patch (as they are displayed in show > mode)
`buffer-substring-no-properties' grabs the text of the rendered buffer without any properties, and images are inserted using properties. You could replace it with `buffer-substring' to see the images in the reply buffer (but see previous comments about what happens when you send). > I guess my concern with adding to the show code is that is already > more complicated than I would like (invisibility, hidden parts, lazy > parts etc). One complex piece of code that knows how to iterate over messages display the parts seems enough - why have two? -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 310 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20140512/4d44abfb/attachment.pgp>
