On Mon, 12 May 2014, David Edmondson <dme at dme.org> wrote: > emacs: Improve the cited message included in replies > > I tried to do things in small increments to make it easier to review. > > v2: > - Don't run the text/plain hooks when generating the message to quote. > > v3: > - Remove the 'no-button code, as it's no longer used. > - Control the insertion of part headers using a function. > - Fix the tests.
I think I broadly like this series. I haven't thought through all the ramifications yet so this is just some first thoughts. I will also send some comments on individual patches. In notmuch-show we go to notmuch-show-insert-part-*/* to notmuch-mm-display-part-inline and then leave the decision to inline to mm-inlined-types. I think this means that, by default, we will not inline signatures amongst other things. So at the least I think we should decide whether we want to override mm-inlined-types. Alternatively, and in my view preferably, we could have a function or variable of our own which says which parts to include. Indeed, if do it with a function we might be able to make an option to reply to mean "include parts currently shown in the notmuch-show buffer" which might be nice. There is a related question and possible bug that we might be able to do something about at the same time: should we include text parts in the reply if they have content-disposition attachment? I have been caught about by this on one occasion replying to a message with a 500K log file attached (and notmuch-show/wash becomes very slow with a 500K message!) Finally, I am not sure whether I like having buttons in the reply. My instinct is against, but they do add context. Best wishes Mark > > > David Edmondson (9): > emacs/show: Re-arrange determination if a part header is necessary > emacs/show: Allow the user to decide when part headers should be > inserted > emacs/show: Accommodate the lack of part header buttons > emacs/mua: Generate improved cited text for replies > emacs/show: Remove the 'no-buttons option of > `notmuch-show-insert-bodypart' > emacs/mua: Don't insert part headers in citations > test: Update the test output to accord with the reply changes > emacs/mua: Insert part headers depending on the message > test: Update the test output to accord with more reply changes > > emacs/notmuch-mua.el | 82 +++++++++++++++++++----------- > emacs/notmuch-show.el | 135 > +++++++++++++++++++++++++++++++------------------- > test/T310-emacs.sh | 44 ++++++++++++++++ > 3 files changed, 180 insertions(+), 81 deletions(-) > > -- > 2.0.0.rc0 > > _______________________________________________ > notmuch mailing list > notmuch at notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch
