On Fri, Sep 19 2014, David Bremner wrote: > Jani Nikula <jani at nikula.org> writes: > >> + if (name && *name) >> + full_address = talloc_asprintf (NULL, "%s <%s>", name, addr); >> + else >> + full_address = talloc_asprintf (NULL, "<%s>", addr > > Is there some reason not to use sprinter as a talloc context here? > >> + >> + if (!full_address) >> + break; > > Is the error here out of memory? Maybe an error message would be a good > idea. > > > Obviously the docs need to be updated as well, and ideally the tests. I > think Jani was hinting that he didn't want to be the person to do > that. Any volunteers?
Yes, I'll look at that. It will probably take me a few days. -Michal
