On Wed, Sep 24, 2014 at 05:32:50PM -0400, Austin Clements wrote: > + * If the caller is currently in an atomic section (there was a > + * notmuch_database_begin_atomic without a matching > + * notmuch_database_end_atomic), this will abort the atomic section, > + * discarding any modifications made in the atomic section. All > + * changes up to this will be committed.
I still think Xapian's wording is more readable [1]: For a WritableDatabase, if a transaction is active it will be aborted, while if no transaction is active commit() will be implicitly called. How about: For a writable database, if a transaction is active (there was a notmuch_database_begin_atomic without a matching notmuch_database_end_atomic) it will be aborted, while if no transaction is active any pending changes will be committed. Cheers, Trevor [1]: http://xapian.org/docs/apidoc/html/classXapian_1_1Database.html#a59f5f8b137723dcaaabdbdccbc0cf1eb -- This email may be signed or encrypted with GnuPG (http://www.gnupg.org). For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: OpenPGP digital signature URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20140924/b15fa880/attachment.pgp>