On Fri, Oct 31, 2014 at 02:04:50PM -0400, Jesse Rosenthal wrote: > W. Trevor King writes: > > On Fri, Oct 31, 2014 at 01:33:25PM -0400, Jesse Rosenthal wrote: > >> We instead initalize the dictionary using the dict comprehension > >> and then update it with the values from the tree. This will work > >> with both python2 and python3. > > > > Dict comprehensions are new in 2.7 [1,2], so this drops support > > for systems where ?python? means ?python2.6?. Personally, I'm > > fine with that, but I thought I'd point it out in case 2.6 users > > wanted to push back ;). > > The comprehension was already in the previous version, so I figured that > people were already cool with 2.7+.
Ah, good point :). Besides looking good to me, I can confirm that I see a TypeError (and a lot of CPU usage ;) from T260-thread-order.sh before this patch which is fixed by this patch. Cheers, Trevor -- This email may be signed or encrypted with GnuPG (http://www.gnupg.org). For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: OpenPGP digital signature URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20141031/4d4eaff3/attachment-0001.pgp>