The two remaining cases in the lib seem to require more than a simple replacement of the old call, with the new call plus a check of the return value. --- lib/database.cc | 2 ++ lib/thread.cc | 2 ++ 2 files changed, 4 insertions(+)
diff --git a/lib/database.cc b/lib/database.cc index 78a24f7..15619c3 100644 --- a/lib/database.cc +++ b/lib/database.cc @@ -1388,6 +1388,8 @@ notmuch_database_upgrade (notmuch_database_t *notmuch, notmuch_message_t *message; char *filename; + /* XXX: this should use the _st version, but needs an error + path */ for (messages = notmuch_query_search_messages (query); notmuch_messages_valid (messages); notmuch_messages_move_to_next (messages)) diff --git a/lib/thread.cc b/lib/thread.cc index 9847cf8..c8e58c3 100644 --- a/lib/thread.cc +++ b/lib/thread.cc @@ -504,6 +504,8 @@ _notmuch_thread_create (void *ctx, * oldest or newest subject is desired. */ notmuch_query_set_sort (thread_id_query, NOTMUCH_SORT_OLDEST_FIRST); + /* XXX: this should use the _st version, but it needs an error path + */ for (messages = notmuch_query_search_messages (thread_id_query); notmuch_messages_valid (messages); notmuch_messages_move_to_next (messages)) -- 2.1.4