On Sun 08 Apr 2018 at 19:14 -0300, David Bremner wrote: > Floris Bruynooghe <f...@devork.be> writes: > >> This series looks good to me, would be great to have! Do you want to >> commit them this or should I just incorporate it and submit together >> with tests once actual tests exist. You could always commit with a ``def >> test_dummy(): assert True`` or something if you like. >> > > For now, why don't you just incorporate them. Maybe you'll discover some > issues with them as you work up some real tests.
Sure, that works. > BTW, it seems like a > reasonable plan to get a set of unit tests for the existing bindings > first to help with migration. Is that what you had in mind? Yes that's what I had in mind. To safely swap out ctypes for cffi adding tests to ensure the existing API behaviour remains is a must. Which reminds me that it's probably worth calling this out explicitly again: this works implies that cffi will become an external dependency  for the existing bindings. Just want to make sure this doesn't become an issue further down the line. Cheers, Floris  Technically only on cpython, it's bundled with pypy. _______________________________________________ notmuch mailing list firstname.lastname@example.org https://notmuchmail.org/mailman/listinfo/notmuch