On Thu, Jun 13 2019, David Bremner wrote:

> From: uncrustify <da...@tethera.net>
>
> This is the result of running
>
>      $ uncrustify --replace --config devel/uncrustify.cfg *.c *.h
>
> in the top level source directory
> ---

Everything else than this one thing below and what I noticed looked like
what I've remembered uncrustify did (in 2014). IMO tolerable. We can see 
later if there is anything to improve -- it is easier when delta is small...

Series up to this poing pretty good...

Tomi

// ... stuff deleted ... //

> diff --git a/notmuch-config.c b/notmuch-config.c
> index b7f0784f..f16410a1 100644
> --- a/notmuch-config.c
> +++ b/notmuch-config.c
> @@ -300,20 +300,20 @@ out:
>   *
>   *   If is_new_ret is NULL, then a "file not found" message will be
>   *   printed to stderr and NULL will be returned.
> -
> + *
>   *   If is_new_ret is non-NULL then a default configuration will be
>   *   returned and *is_new_ret will be set to 1 on return so that
>   *   the caller can recognize this case.
>   *
> - *   These default configuration settings are determined as
> - *   follows:
> + *      These default configuration settings are determined as
> + *      follows:

The change above looks strange, why change tabs to spaces, if not elsewhere

>   *
>   *           database_path:          $MAILDIR, otherwise $HOME/mail
>   *
>   *           user_name:              $NAME variable if set, otherwise
>   *                                   read from /etc/passwd
>   *
> - *           user_primary_mail:      $EMAIL variable if set, otherwise
> + *           user_primary_mail:      $EMAIL variable if set, otherwise

The above I',m not sure; '> +' disturbs experience too much ;/

... have to create worktree and apply series to see better...

>   *                                   constructed from the username and
>   *                                   hostname of the current machine.

_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Reply via email to