On Mon 2019-06-24 21:44:13 +0300, Tomi Ollila wrote: > If this suite speedup is merged, I'd suggest using original David's patch > 2/2 due to consistency reasons -- $gen_test_filename is used likewise in > other test_expect_code cases. and, unless $TEST_DIRECTORY contains '"'s, > '$'s or '`'s it work (in our current cases $gen_test_name does not contain > the above characters (gen_test_filename=$TEST_DIRECTORY/$gen_test_name)) > > I've looked this quite a lot lately (mostly for fun). I'll send email in > near future some suggestions (ten (10) or so) how we could improve the > situation here, which then could be applied everywhere...
If you insist, i'm ok to wait on your cleanup for pathnames that have unusual characters in them, though i'd also be happy to see the cleanup applied to make *inconsistent* things consistent, rather than enforcing a broken-yet-uniform consistency and then applying the cleanup. But we should not use Bremner's patch 2/2 directly, because it moves shim generation below gen_insert_msg, as mentioned in id:8736kipe9f....@fifthhorseman.net. --dkg
Description: PGP signature
_______________________________________________ notmuch mailing list email@example.com https://notmuchmail.org/mailman/listinfo/notmuch