On Thu 15 Aug 2019 at 09:28 -0300, David Bremner wrote: > Floris Bruynooghe <f...@devork.be> writes: > >> On Wed 14 Aug 2019 at 16:20 -0300, David Bremner wrote: >>> >>> Can you remind me what the percieved blockers are for merging into the >>> main notmuch tree? I'm less hung up on python2 compatibility than I used >>> to be, fwiw. I'd be ok with shipping the old python2 bindings in contrib >>> for a bit for those who still need/want them, but concentrate our >>> maintenance effort on the cffi bindings. >> >> IIRC it was mostly about how to support transitioning from one API to >> the other since currently there's no compatibility. I guess there's >> nothing stopping one from using both APIs in one codebase though, AFAIK >> Xapian handles the required locking. But some of the discussions >> suggested being able to create a new Message object from an old one etc, >> allowing you to do more mixing during a transition period. This is the >> part that I said is possible but a lot of work and questionable if no >> one thought they'd be using it. >> > > Ah right. Well, given the impending removal of python2 from various > places (e.g. debian testing), I don't think we should be that > fussy/ambitious. > > I'd propose > > - add the new cffi based bindings, using a distinct name (as you already > have). > > - deprecate the old ones > > - port any internal dependencies to the new bindings > > - finally drop the old bindings or move them to contrib/ for people slow > in switching. > > I think for the first step we only need a reasonable looking patch > (series?) from you.
Sounds reasonable, just a quick note that I'm on holiday at the moment and generally won't be too quick. But I guess there's no rush. I was also trying to improve the docs but got sidetracked at some point. There should be already reasonable good docstrings though. For path series what did you have in mind? One single patch with the whole lot? The original history at https:://github/flub/notdb? Something in between? I also recall some comments about the naming not being liked much (notdb). I'm open to some bikeshedding on the naming if it bothers people. I was only aiming for something short but under a different import name, which are probably still useful features to keep. Cheers, Floris _______________________________________________ notmuch mailing list email@example.com https://notmuchmail.org/mailman/listinfo/notmuch