Olivier Taïbi <o...@olitb.net> writes: Thanks for the mail. In general we need each change in a separate patch for review. Being zlib related is not really close enough for us.
> the following diff addresses 3 zlib-related bugs in notmuch. > 1) the second argument of gzerror() cannot be NULL, so replace it by a dummy > &errnum. I've incorporated this change into another related series, thanks for the report. > 2) gzerror() cannot be closed after gzclosed(), so just print the error value > instead. That seems legit. To speed things up, you could make a separate patch, rebased against master. > 3) in gz_getline(), if gz_error sets its second argument to Z_STREAM_END then > there was no error (only EOF). Unfortunately the zlib manual is not very > clear on the meaning of Z_STREAM_END, but I don't see how it could be an > error. I found this issue by using notmuch on OpenBSD, which has an old > zlib. I encountered other issues with notmuch on OpenBSD (e.g. there is no > transparency mode in this older zlib, so notmuch dump output is always > gzipped), but they do not seem to be bugs in notmuch. I have to think / read about this more. A separate patch would help here as well. d _______________________________________________ notmuch mailing list email@example.com https://notmuchmail.org/mailman/listinfo/notmuch