David Bremner <da...@tethera.net> writes:

> Jonas Bernoulli <jo...@bernoul.li> writes:
>
>> +compile-elisp-tests:
>> +    $(EMACS) --batch -L emacs -L test -l notmuch.el -l test-lib.el -f \
>> +    batch-byte-compile test/*.el
>> +
>
> Can you explain a bit (perhaps in an updated commit message) why we need
> this target?

The tests might have issues that can be detected by the byte-compiler.
The only issue that I actually did detect was the one fixed by 3/3,
which is a very minor cosmetic issue.

However if someone modified the tests, then they might of course add
more serious issues.  If they ran this target, then they might detect
that.  But they might forget to do so.  They might also forget to re-run
this target after making changes.

Therefore I retract this commit at least in the current form. I might
include an improved more thoroughly described version of this in a later
patch series.  For now please just apply 3/3.

     Jonas
_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Reply via email to