Tomi Ollila venit, vidit, dixit 2022-02-09 21:47:46: > On Wed, Feb 09 2022, Michael J. Gruber wrote: > > > Specifying test comparisons as "expected actual" gives a better readable > > diff since the "-" indicates missing, "+" additional items compared to > > the expectations. > > > > Signed-off-by: Michael J Gruber <g...@grubix.eu> > > --- > > test/T380-atomicity.sh | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/test/T380-atomicity.sh b/test/T380-atomicity.sh > > index afe49d93..a6f1e037 100755 > > --- a/test/T380-atomicity.sh > > +++ b/test/T380-atomicity.sh > > @@ -93,7 +93,7 @@ if test_require_external_prereq gdb; then > > fi > > > > test_begin_subtest '"notmuch new" is idempotent under arbitrary aborts' > > -test_expect_equal_file searchall expectall > > +test_expect_equal_file expectall searchall > > Good in princible, but if things are like decade ago, we still have > hundreds of these in wrong order -- if so, all should be changed for > consistency. If I am wrong and all / many of those are already changed, > then this is OK.
I haven't checked, but the order add to the confusion created by "detected >10 abort points" which is why I changed it here, and in order to (mis-)use these files in the following commits. > > > > test_begin_subtest "detected $outcount>10 abort points" > > test_expect_success "test $outcount -gt 10" > > -- > > 2.35.1.306.ga00bde9711 _______________________________________________ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
