On Sun, 26 Jul 2009 21:08:09 +1000 Dave Airlie <[email protected]> wrote:
> On Sun, Jul 26, 2009 at 9:03 PM, Dave Airlie<[email protected]> wrote: > > On Sat, Jul 25, 2009 at 10:29 PM, Pekka Paalanen<[email protected]> wrote: > >> Remove the use of drm_local_map for the FB mapping and replace it with > >> the equivalent ioremap. > > > > I don't think FBs are ioremapped normally with addmap, unless nouveau > > does something different here. Generally ioremapping the whole framebuffer > > is considered a bad idea as ioremap on 32-bit x86 is limited. > > > > /me reads patch properly ;-) > > Notice DRM_REGISTERS. oops. looks fine then. Yeah, the name '->fb' could be better, but at least there's a comment in the code that it's not really the whole FB :-P Thanks for the review. -- Pekka Paalanen http://www.iki.fi/pq/ _______________________________________________ Nouveau mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/nouveau
