On Sun, Jun 13, 2010 at 11:56:54PM +0200, Marcin Slusarz wrote: > After every iounmap mmiotrace has to free kmmio_fault_pages, but it > can't do it directly, so it defers freeing by RCU. > > It usually works, but when mmiotraced code calls ioremap-iounmap > multiple times without sleeping between (so RCU won't kick in and > start freeing) it can be given the same virtual address, so at > every iounmap mmiotrace will schedule the same pages for release. > Obviously it will explode on second free. > > Fix it by marking kmmio_fault_pages which are scheduled for release > and not adding them second time. > > Signed-off-by: Marcin Slusarz <[email protected]> > Acked-by: Pekka Paalanen <[email protected]> > Cc: Stuart Bennett <[email protected]> > Tested-by: Marcin Kościelnicki <[email protected]> > Tested-by: Shinpei KATO <[email protected]> > ---
It would be good to apply it to -stable too. Sometimes people has to test some earlier kernels because of unfixable constraints (you know, these uncooperative vendors not releasing their binary drivers for latest kernels) Marcin _______________________________________________ Nouveau mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/nouveau
