On Sun, May 06, 2012 at 09:01:49PM +0200, Marcin Kościelnicki wrote: > On 06.05.2012 20:51, Marcin Slusarz wrote: > > > > --- > > rnndb/nv50_pgraph.xml | 3 +++ > > 1 files changed, 3 insertions(+), 0 deletions(-) > > > > diff --git a/rnndb/nv50_pgraph.xml b/rnndb/nv50_pgraph.xml > > index 92d69ea..6499631 100644 > > --- a/rnndb/nv50_pgraph.xml > > +++ b/rnndb/nv50_pgraph.xml > > @@ -93,6 +93,9 @@ > > <value value="0x23" name="XY_OUT_OF_BOUNDS"> <!-- m2mf at least. 2d > > too? --> > > <brief>Your x/y coords exceed the size of your surface.</brief> > > </value> > > + <value value="0x24" name="VP_NO_INPUT_MASK"> > > + <brief>You tried to submit vertices without setting input mask > > (VP_ATTR_EN).</brief> > > + </value> > > <value value="0x27" name="CP_MORE_PARAMS_THAN_SHARED"> > > <brief>You tried to launch block with more params than > > allocated s[] space.</brief> > > </value> > > Could we get a better name + description for that? The error happens > when there are no enabled inputs (VP_ATTR_EN is set, but is 0), not when > it's not set at all. VP_ZERO_INPUTS or VP_NO_INPUTS perhaps?
Yes, that's correct. > Also, have you checked if that error happens on all submission methods, > or just VERTEX_DATA? I don't see why VERTEX_ELEMENT / > VERTEX_BUFFER_COUNT would have a problem with 0 inputs. It definitely has problems with VERTEX_BUFFER_COUNT, only later I discovered VERTEX_DATA have them too. I didn't check VB_ELEMENT_*, but I bet it's the same story. Marcin --- From: Marcin Slusarz <[email protected]> Subject: [PATCH] nv50/pgraph: DATA_ERROR 0x24 --- rnndb/nv50_pgraph.xml | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/rnndb/nv50_pgraph.xml b/rnndb/nv50_pgraph.xml index 92d69ea..aa925fa 100644 --- a/rnndb/nv50_pgraph.xml +++ b/rnndb/nv50_pgraph.xml @@ -93,6 +93,9 @@ <value value="0x23" name="XY_OUT_OF_BOUNDS"> <!-- m2mf at least. 2d too? --> <brief>Your x/y coords exceed the size of your surface.</brief> </value> + <value value="0x24" name="VP_ZERO_INPUTS"> + <brief>You tried to submit vertices with VP input mask (VP_ATTR_EN) set to 0.</brief> + </value> <value value="0x27" name="CP_MORE_PARAMS_THAN_SHARED"> <brief>You tried to launch block with more params than allocated s[] space.</brief> </value> -- 1.7.8.5 _______________________________________________ Nouveau mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/nouveau
