On Fri, Sep 14, 2012 at 01:45:18PM +0200, Marcin Slusarz wrote: > On Fri, Sep 14, 2012 at 04:44:59PM +1000, Ben Skeggs wrote: > > On Fri, Sep 14, 2012 at 12:21:33AM +0200, Marcin Slusarz wrote: > > > Otherwise my card (nv92) never resumes from suspend to ram, hanging on > > > nv_mask in nv50_gpio_drive. Before rework, initialization was done only > > > from POST, so this patch restores previous behaviour. > > This patch would break the cold-boot behaviour (DEVINIT needs GPIO etc > > to have been created so it can call out to them). > > > > I've modified nouveau git so that it restores the behaviour of the first > > version of the rework and has DEVINIT be the first in the init ordering, > > but delays its init until all its dependencies have been created. > > > > Can you confirm your issue is resolved now? > > Yes. > > Two thoughts: > > Your commit message states that the next commit triggers the bad behaviour, > but it's not completely true - I had resume lockups even before this commit > hit the tree. Though I don't know what was the problem. > > It's a bit sad when ones spends a lot of time on debugging something and > the patch is redone the next day by the maintainer. If you would give me > the feedback on the patch, I would improve it and resend. Had it been a straight-forward can-just-be-applied-on-top-or-squashed-simply, I would have done so. This particular case though resulted in dropping another patch from the tree too (that was no longer needed due to the changed ordering), so I figured it'd be simpler for me to just do it all in one step.
Ben. > > Marcin _______________________________________________ Nouveau mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/nouveau
