Re: [Nouveau] [PATCH] drm/nouveau: Do not show an error if the TMDS table pointer is invalid

[Albert Pool]

Thank you for your reply. I hope I won't forget to upload the BIOS of Joey4712's NVE7 to the repo tomorrow, then you guys can take a look at it too. That is a GPU without any outputs and it triggers this message.

I'm writing this on my phone, so don't have the file at hand right now.

 

Albert

 

------ Origineel bericht ------
Van: Ben Skeggs
Datum: 09-10-2013 22:55
Naar: Albert Pool;
CC: nouveau@lists.freedesktop.org;
Onderwerp:Re: [Nouveau] [PATCH] drm/nouveau: Do not show an error if the TMDS table pointer is invalid

On Thu, Oct 10, 2013 at 5:40 AM, Albert Pool  wrote:
> Optimus cards with no outputs trigger this message (NVD7, for example)
> This commit changes the warning into an informational message.
> The return value of the function is not used, so I left it at -EINVAL.
>
> Signed-off-by: Albert Pool 
> Cc: Emil Velikov 
> ---
>  drivers/gpu/drm/nouveau/nouveau_bios.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c
> index 3e72876..7681b01 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_bios.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c
> @@ -936,7 +936,8 @@ static int parse_bit_tmds_tbl_entry(struct drm_device *dev, struct nvbios *bios,
>
>         tmdstableptr = ROM16(bios->data[bitentry->offset]);
>         if (!tmdstableptr) {
> -               NV_ERROR(drm, "Pointer to TMDS table invalid\n");
> +               /* Happens on NVD7 and other Optimus cards with no outputs */
> +               NV_INFO(drm, "TMDS table not found\n");
Hmm, ideally this code wouldn't exist anymore, but we're not there
yet.  So, I'll take the patch.  But, I suspect NV_DEBUG() will be
better here, anyone looking will likely thing "not found" means an
error anyway.

Thanks,
Ben.

>                 return -EINVAL;
>         }
>
> --
> 1.7.10.4
>
> _______________________________________________
> Nouveau mailing list
> Nouveau@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/nouveau

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau