On Fri, Mar 13, 2015 at 7:11 AM, Ilia Mirkin <[email protected]> wrote: > I guess Alexandre will help you prepare this for upstream inclusion, > but just want to make sure that my main point makes it across -- this > is a 3K line patch. Please try to split it up into patches that add no > more than 300 lines at a time, preferably fewer (but this isn't always > possible). Ideally each patch should introduce one conceptual unit. Of > course different people might draw the line of "conceptual unit" > differently, but try to do it so that each one becomes 100-300 lines > of code :)
Yes, please let me take care of the first few rounds of reviews. I don't know how much this patch can be split though, as it is supposed to be the "basic" stuff for PMU. :) Anyway, will come again later today with a thorough review. _______________________________________________ Nouveau mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/nouveau
