Hi,

On 02-10-15 09:26, Ilia Mirkin wrote:
On Fri, Oct 2, 2015 at 3:18 AM, Hans de Goede <[email protected]> wrote:
Hi,

On 02-10-15 05:41, Ilia Mirkin wrote:

<nothing>

As someone who has recently started following nouveau I must say that
it would greatly help me (and likely others) if patches likes this would
come with a somewhat more descriptive commit message.

Duly noted. I normally try to say a bit, but have gotten lazy of late.
Ben's pretty terse too :) How about something like

"""
Currently OF bios load fails for a few reasons:
  - checksum failure
  - bios size too small
  - no PCIR header
  - bios length not a multiple of 4

In this change, we resolve all of the above by ignoring any checksum
failures, and faking the PCIR data when loading from OF.
"""

Much better, I must say that now that you spell it out that the
ignoring of the checksum sort of worries me, but I guess the
checksum is part of the missing PCIR header ?

Regards,

Hans
_______________________________________________
Nouveau mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/nouveau

Reply via email to