On Wed, Aug 24, 2016 at 03:11:12PM +0300, Martin Peres wrote: > On 23/08/16 17:43, Emil Velikov wrote: > > On 23 August 2016 at 00:42, Martin Peres <[email protected]> wrote: > > > v2: > > > - guard LED framework calls with ifdef CONFIG_LEDS_CLASS > > > > > IIRC kernel has the tendency of using static inlines in the headers > > when CONFIG_foo is not set. Worth using that and removing the ifdef > > from the source file ? > > Oh, you mean, re-defining the functions I use but make them do nothing. > > However, I should do it in the source file and not in the header since I do > not want to export these symbols outside of the object. > > Do you have an example to share? Anyway, this seems like a good > candidate to reduce the number of ifdefs. Thanks!
See Documentation/CodingStyle, "Chapter 20: Conditional Compilation". Plenty examples are in include/linux/. Best regards, Lukas _______________________________________________ Nouveau mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/nouveau
