I am a little unsure about the change in nouveau_fence, maybe somebody
with more knowledge about the code can look into it?

Signed-off-by: Karol Herbst <[email protected]>
---
 drm/nouveau/dispnv04/arb.c            | 6 ++----
 drm/nouveau/nouveau_fence.c           | 2 --
 drm/nouveau/nvkm/subdev/fb/ramgk104.c | 4 +---
 3 files changed, 3 insertions(+), 9 deletions(-)

diff --git a/drm/nouveau/dispnv04/arb.c b/drm/nouveau/dispnv04/arb.c
index a555681..4bbd83a 100644
--- a/drm/nouveau/dispnv04/arb.c
+++ b/drm/nouveau/dispnv04/arb.c
@@ -55,8 +55,8 @@ struct nv_sim_state {
 static void
 nv04_calc_arb(struct nv_fifo_info *fifo, struct nv_sim_state *arb)
 {
-       int pagemiss, cas, width, bpp;
-       int nvclks, mclks, pclks, crtpagemiss;
+       int pagemiss, cas, bpp;
+       int nvclks, mclks, crtpagemiss;
        int found, mclk_extra, mclk_loop, cbs, m1, p1;
        int mclk_freq, pclk_freq, nvclk_freq;
        int us_m, us_n, us_p, crtc_drain_rate;
@@ -67,11 +67,9 @@ nv04_calc_arb(struct nv_fifo_info *fifo, struct nv_sim_state 
*arb)
        nvclk_freq = arb->nvclk_khz;
        pagemiss = arb->mem_page_miss;
        cas = arb->mem_latency;
-       width = arb->memory_width >> 6;
        bpp = arb->bpp;
        cbs = 128;
 
-       pclks = 2;
        nvclks = 10;
        mclks = 13 + cas;
        mclk_extra = 3;
diff --git a/drm/nouveau/nouveau_fence.c b/drm/nouveau/nouveau_fence.c
index 098044c..e1ead6f 100644
--- a/drm/nouveau/nouveau_fence.c
+++ b/drm/nouveau/nouveau_fence.c
@@ -154,10 +154,8 @@ nouveau_fence_wait_uevent_handler(struct nvif_notify 
*notify)
        spin_lock_irqsave(&fctx->lock, flags);
        if (!list_empty(&fctx->pending)) {
                struct nouveau_fence *fence;
-               struct nouveau_channel *chan;
 
                fence = list_entry(fctx->pending.next, typeof(*fence), head);
-               chan = rcu_dereference_protected(fence->channel, 
lockdep_is_held(&fctx->lock));
                if (nouveau_fence_update(fence->channel, fctx))
                        ret = NVIF_NOTIFY_DROP;
        }
diff --git a/drm/nouveau/nvkm/subdev/fb/ramgk104.c 
b/drm/nouveau/nvkm/subdev/fb/ramgk104.c
index 7904fa4..fb8a123 100644
--- a/drm/nouveau/nvkm/subdev/fb/ramgk104.c
+++ b/drm/nouveau/nvkm/subdev/fb/ramgk104.c
@@ -989,7 +989,7 @@ gk104_pll_calc_hiclk(int target_khz, int crystal,
                int *N1, int *fN1, int *M1, int *P1,
                int *N2, int *M2, int *P2)
 {
-       int best_clk = 0, best_err = target_khz, p_ref, n_ref;
+       int best_err = target_khz, p_ref, n_ref;
        bool upper = false;
 
        *M1 = 1;
@@ -1010,7 +1010,6 @@ gk104_pll_calc_hiclk(int target_khz, int crystal,
                        /* we found a better combination */
                        if (cur_err < best_err) {
                                best_err = cur_err;
-                               best_clk = cur_clk;
                                *N2 = cur_N;
                                *N1 = n_ref;
                                *P1 = p_ref;
@@ -1022,7 +1021,6 @@ gk104_pll_calc_hiclk(int target_khz, int crystal,
                                - target_khz;
                        if (cur_err < best_err) {
                                best_err = cur_err;
-                               best_clk = cur_clk;
                                *N2 = cur_N;
                                *N1 = n_ref;
                                *P1 = p_ref;
-- 
2.10.1

_______________________________________________
Nouveau mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/nouveau

Reply via email to