[Nouveau] [PATCH v4 9/33] secboot: add LS flags to LS func structure

[Alexandre Courbot]

Add a flag that can be set when declaring how a LS firmware should be
loaded. This allows us to remove falcon-specific code in the loader.

Signed-off-by: Alexandre Courbot <acour...@nvidia.com>
---
 drm/nouveau/nvkm/subdev/secboot/acr_r352.c | 10 ++++------
 drm/nouveau/nvkm/subdev/secboot/acr_r352.h |  2 ++
 drm/nouveau/nvkm/subdev/secboot/acr_r361.c |  2 ++
 3 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/drm/nouveau/nvkm/subdev/secboot/acr_r352.c 
b/drm/nouveau/nvkm/subdev/secboot/acr_r352.c
index 5622ae9c1a1e..716e9d915765 100644
--- a/drm/nouveau/nvkm/subdev/secboot/acr_r352.c
+++ b/drm/nouveau/nvkm/subdev/secboot/acr_r352.c
@@ -265,13 +265,9 @@ ls_ucode_img_fill_headers(struct acr_r352 *acr, struct 
ls_ucode_img *img,
                             desc->app_resident_data_offset;
        lhdr->app_data_size = desc->app_resident_data_size;
 
-       lhdr->flags = 0;
+       lhdr->flags = func->lhdr_flags;
        if (img->falcon_id == acr->base.boot_falcon)
-               lhdr->flags = LSF_FLAG_DMACTL_REQ_CTX;
-
-       /* GPCCS will be loaded using PRI */
-       if (img->falcon_id == NVKM_FALCON_GPCCS)
-               lhdr->flags |= LSF_FLAG_FORCE_PRIV_LOAD;
+               lhdr->flags |= LSF_FLAG_DMACTL_REQ_CTX;
 
        /* Align and save off BL descriptor size */
        lhdr->bl_data_size = ALIGN(func->bl_desc_size, LSF_BL_DATA_SIZE_ALIGN);
@@ -866,6 +862,8 @@ acr_r352_ls_gpccs_func = {
        .load = acr_ls_ucode_load_gpccs,
        .generate_bl_desc = acr_r352_generate_flcn_bl_desc,
        .bl_desc_size = sizeof(struct acr_r352_flcn_bl_desc),
+       /* GPCCS will be loaded using PRI */
+       .lhdr_flags = LSF_FLAG_FORCE_PRIV_LOAD,
 };
 
 const struct acr_r352_func
diff --git a/drm/nouveau/nvkm/subdev/secboot/acr_r352.h 
b/drm/nouveau/nvkm/subdev/secboot/acr_r352.h
index 38ac2a73f585..d54deea763a1 100644
--- a/drm/nouveau/nvkm/subdev/secboot/acr_r352.h
+++ b/drm/nouveau/nvkm/subdev/secboot/acr_r352.h
@@ -52,12 +52,14 @@ struct hsf_load_header {
  * @generate_bl_desc: function called on a block of bl_desc_size to generate 
the
  *                   proper bootloader descriptor for this LS firmware
  * @bl_desc_size: size of the bootloader descriptor
+ * @lhdr_flags: LS flags
  */
 struct acr_r352_ls_func {
        int (*load)(const struct nvkm_subdev *, struct ls_ucode_img *);
        void (*generate_bl_desc)(const struct nvkm_acr *,
                                 const struct ls_ucode_img *, u64, void *);
        u32 bl_desc_size;
+       u32 lhdr_flags;
 };
 
 /**
diff --git a/drm/nouveau/nvkm/subdev/secboot/acr_r361.c 
b/drm/nouveau/nvkm/subdev/secboot/acr_r361.c
index d2c01af50d2e..9373a724f87e 100644
--- a/drm/nouveau/nvkm/subdev/secboot/acr_r361.c
+++ b/drm/nouveau/nvkm/subdev/secboot/acr_r361.c
@@ -113,6 +113,8 @@ acr_r361_ls_gpccs_func = {
        .load = acr_ls_ucode_load_gpccs,
        .generate_bl_desc = acr_r361_generate_flcn_bl_desc,
        .bl_desc_size = sizeof(struct acr_r361_flcn_bl_desc),
+       /* GPCCS will be loaded using PRI */
+       .lhdr_flags = LSF_FLAG_FORCE_PRIV_LOAD,
 };
 
 const struct acr_r352_func
-- 
git-series 0.8.10
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau