On Sat, Jan 19, 2019 at 6:38 PM Rhys Kidd <[email protected]> wrote: > > On Sat, 19 Jan 2019 at 18:32, Ilia Mirkin <[email protected]> wrote: >> >> Is vlCreateAdaptorXvMC just silly, or does it really want to take >> ownership of the name pointer? > > > vlCreateAdaptorXvMC( ) doesn't need to take over ownership of the name > pointer, so yes - I guess it's being silly in one respect by not being > specific about const.
OK. I'm not a fan of these types of casts, but it's also pretty minor. However I'd appreciate the subject getting renamed to "silence" rather than "fix", since it's not fixing anything (in fact it's arguably introducing a bug). Reviewed-by: Ilia Mirkin <[email protected]> > >> >> >> On Sat, Jan 19, 2019 at 6:30 PM Rhys Kidd <[email protected]> wrote: >> > >> > Fixes warning with gcc 8.2: >> > >> > nouveau_xv.c: In function ‘NVInitVideo’: >> > nouveau_xv.c:2247:68: warning: passing argument 2 of ‘vlCreateAdaptorXvMC’ >> > discards ‘const’ qualifier from pointer target type >> > [-Wdiscarded-qualifiers] >> > adaptorsXvMC[0] = vlCreateAdaptorXvMC(pScreen, >> > textureAdaptor[0]->name); >> > ~~~~~~~~~~~~~~~~~^~~~~~ >> > In file included from nouveau_xv.c:42: >> > vl_hwmc.h:6:63: note: expected ‘char *’ but argument is of type ‘const >> > char *’ >> > XF86MCAdaptorPtr vlCreateAdaptorXvMC(ScreenPtr pScreen, char >> > *xv_adaptor_name); >> > >> > ~~~~~~^~~~~~~~~~~~~~~ >> > >> > Signed-off-by: Rhys Kidd <[email protected]> >> > --- >> > src/nouveau_xv.c | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/src/nouveau_xv.c b/src/nouveau_xv.c >> > index a7ec21a..3258ef7 100644 >> > --- a/src/nouveau_xv.c >> > +++ b/src/nouveau_xv.c >> > @@ -2244,7 +2244,7 @@ NVInitVideo(ScreenPtr pScreen) >> > XF86MCAdaptorPtr *adaptorsXvMC = >> > malloc(sizeof(XF86MCAdaptorPtr)); >> > >> > if (adaptorsXvMC) { >> > - adaptorsXvMC[0] = vlCreateAdaptorXvMC(pScreen, >> > textureAdaptor[0]->name); >> > + adaptorsXvMC[0] = vlCreateAdaptorXvMC(pScreen, >> > (char *)textureAdaptor[0]->name); >> > >> > if (adaptorsXvMC[0]) { >> > vlInitXvMC(pScreen, 1, adaptorsXvMC); >> > -- >> > 2.19.1 >> > >> > _______________________________________________ >> > Nouveau mailing list >> > [email protected] >> > https://lists.freedesktop.org/mailman/listinfo/nouveau _______________________________________________ Nouveau mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/nouveau
