On Fri, 12 Jul 2019 at 00:42, Mark Menzynski <[email protected]> wrote:
> Signed-off-by: Mark Menzynski <[email protected]> > In addition to the general comments I provided to this patch series, you should add a prefix before ":" to the first line of this commit message: Maybe something like "drm/nouveau/bios/gpio: sort gpio function names by value" You can see the general approach with: $ git log -n10 --oneline drivers/gpu/drm/nouveau/include/nvkm/subdev/bios/gpio.h --- > drm/nouveau/include/nvkm/subdev/bios/gpio.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drm/nouveau/include/nvkm/subdev/bios/gpio.h > b/drm/nouveau/include/nvkm/subdev/bios/gpio.h > index b71a3555..2f40935f 100644 > --- a/drm/nouveau/include/nvkm/subdev/bios/gpio.h > +++ b/drm/nouveau/include/nvkm/subdev/bios/gpio.h > @@ -3,9 +3,9 @@ > #define __NVBIOS_GPIO_H__ > enum dcb_gpio_func_name { > DCB_GPIO_PANEL_POWER = 0x01, > + DCB_GPIO_FAN = 0x09, > DCB_GPIO_TVDAC0 = 0x0c, > DCB_GPIO_TVDAC1 = 0x2d, > - DCB_GPIO_FAN = 0x09, > DCB_GPIO_FAN_SENSE = 0x3d, > DCB_GPIO_LOGO_LED_PWM = 0x84, > DCB_GPIO_UNUSED = 0xff, > -- > 2.21.0 > > _______________________________________________ > Nouveau mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/nouveau
_______________________________________________ Nouveau mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/nouveau
