On 9/10/2025 9:25 AM, Alexandre Courbot wrote:
>>> I agree the `: u32` can be introduced later, the original `register!`
>>> macro did not specify any type information so there is indeed no reason
>>> to add it in this patch.
>>>> Yep.
>> When you introduce the types, can you change the syntax from `: u32` to
> `(u32)`? That way the declaration becomes
>
> bitfield! {
> struct ControlReg(u32) {
> ...
> }
> }
>
> ... which at least looks like a valid declaration for a Rust struct
> that wraps a primitive type. Same for registers, if possible.
Sure, I agree with your suggestion and will make the changes.
thanks,
- Joel
- Re: [PATCH v2 4/4] rust: Move register and bits... Joel Fernandes
- Re: [PATCH v2 4/4] rust: Move register and bits... Joel Fernandes
- Re: [PATCH v2 4/4] rust: Move register and ... Joel Fernandes
- Re: [PATCH v2 4/4] rust: Move register and ... Joel Fernandes
- [PATCH v2 1/4] nova-core: bitstruct: Move bitfield-speci... Joel Fernandes
- Re: [PATCH v2 1/4] nova-core: bitstruct: Move bitfi... Alexandre Courbot
- Re: [PATCH v2 1/4] nova-core: bitstruct: Move b... Joel Fernandes
- Re: [PATCH v2 1/4] nova-core: bitstruct: Mo... Alexandre Courbot
- Re: [PATCH v2 1/4] nova-core: bitstruct... Joel Fernandes
- Re: [PATCH v2 1/4] nova-core: bits... Alexandre Courbot
- Re: [PATCH v2 1/4] nova-core: ... Joel Fernandes
- [PATCH v2 3/4] nova-core: bitstruct: Add support for cus... Joel Fernandes
- Re: [PATCH v2 3/4] nova-core: bitstruct: Add suppor... Alexandre Courbot
- Re: [PATCH v2 3/4] nova-core: bitstruct: Add su... Alexandre Courbot
- Re: [PATCH v2 3/4] nova-core: bitstruct: Ad... Joel Fernandes
- Re: [PATCH v2 3/4] nova-core: bitstruct: Add su... Joel Fernandes
- Re: [PATCH v2 3/4] nova-core: bitstruct: Add suppor... Elle Rhumsaa
- Re: [PATCH v2 3/4] nova-core: bitstruct: Add suppor... Elle Rhumsaa
- [PATCH v2 2/4] nova-core: bitstruct: Add support for dif... Joel Fernandes
- Re: [PATCH v2 2/4] nova-core: bitstruct: Add suppor... Alexandre Courbot
- Re: [PATCH v2 2/4] nova-core: bitstruct: Add su... Joel Fernandes
