Re: [PATCH v5 6/9] rust: bitfield: Add KUNIT tests for bitfield

[Joel Fernandes]

On 10/6/2025 12:40 PM, Miguel Ojeda wrote:
> On Sat, Oct 4, 2025 at 6:14 PM Joel Fernandes <joelagn...@nvidia.com> wrote:
>>
>> Well, it can be efficient. It really depends. I have been contributing 
>> upstream for about 15 years if you see the git log, often when someone chats 
>> privately with me like you did and they told me they are ok with a patch, I 
>> save them the trouble and add their review tag especially after they already 
>> added their tag to all my other patches. Surprisingly though this is 
>> probably the first time anyone has been pissed off about it.  Anyway I will 
>> not add your tag henceforth unless you publicly reply (or you let me know 
>> otherwise by chat).
> 
> If they just say they are OK with a patch, that would just mean an
> Acked-by, not a Reviewed-by.
>> In any case, the documentation states those tags cannot be added
> without permission -- if someone gives you a tag privately, it is best
> that you tell them to please send it in the mailing list instead. That
> way there is no confusion and others (including tooling, e.g.
> patchwork and b4) can see it.
Sure, certainly it goes against docs/guidelines to add a tag *without
permission*. I don't think anyone disputed that? I don't think I was advocating
adding RB tags randomly without consent at all - please don't get me wrong. :-)

And no doubts that publicly replying with RB tags is the best way.

cheers,

 - Joel