On 10/25/25 3:01 AM, Danilo Krummrich wrote:
On Sat Oct 25, 2025 at 2:14 AM CEST, John Hubbard wrote:
...
Now you have to open code reading the register, get the Chipset instance and
manually format the revision, which was previously done through a Display impl
of Revision. And the subsequent patch introduces even more open coded logic in
the constructor of struct Gpu.

Instead of removing Spec, we should improve it by giving it its own Display
impl, such that this code can become:


Sure, I'll do it that way.

thanks,
--
John Hubbard

Reply via email to