On 11/15/25 6:13 AM, Alexandre Courbot wrote: ...
+impl From<regs::NV_PMC_BOOT_42> for Revision { + fn from(boot0: regs::NV_PMC_BOOT_42) -> Self { + Self { + major: boot0.major_revision(), + minor: boot0.minor_revision(), + } + } +}Just one nit: similarly to how we are converting the `TryFrom<BOOT_0> for Spec` into a `TryFrom<BOOT_42>`, I think we don't need to keep `From<BOOT_0> for Revision`. Actually we don't even want it, as using it would mean we are relying on BOOT_0 instead of BOOT_42, which this patchset nicely makes our only source of truth. I'll thus remove the `From<BOOT_0>` implementation before applying.
Yes, leaving it in was an oversight, good catch. thanks, -- John Hubbard
