On Sat Nov 15, 2025 at 8:30 AM JST, Timur Tabi wrote:
> This patch set adds basic support for pre-booting GSP-RM
> on Turing.
>
> There is also partial support for GA100, but it's currently not
> fully implemented.  GA100 is considered experimental in Nouveau,
> and so it hasn't been tested with NovaCore either.
>
> That latest linux-firmware.git is required because it contains the
> Generic Bootloader image that has not yet been propogated to
> distros.

Although I had quite a few comments, most should be easy to address and
I think this is looking pretty good already! I am particularly impressed
that there was almost no change to the boot code required.

Two general things to do for future revisions:

- Make sure all patches are properly formatted (using the `rustfmt` build
  target, or better, a hook upon file save in your editor). Doing
  `make rustfmt` on top of this series results in a ~100 LoCs diff.
- Please build with `CLIPPY=1`, this will perform a first pass on things
  that can be written more idiomatically, and a clean clippy is a
  requirement for merging anyway.

Thanks!

Reply via email to