On Fri Jan 16, 2026 at 4:23 AM CET, Alexandre Courbot wrote:
> It looks like John and I have a different opinion on which approach is
> the best to handle the v2/v3 headers (a match in each method vs a new
> trait and virtual method calls).

Unless performance is a concern (which obviously isn't the case here), I think
the dynamic dispatch is fine and leads to cleaner and more maintainable code.

> TBH I don't really mind which approach we adopt, but I would like us to
> stay consistent through the code. This patch adds the trait and
> implements `Deref`, but then the chunk above still performs matches.

Yes, please be consistent -- Alex' diff looks good to me.

Reply via email to