On Sat, 2026-01-17 at 12:09 +0100, Danilo Krummrich wrote:
> 

> > @@ -25,3 +25,8 @@ void rust_helper_dev_set_drvdata(struct device *dev, void 
> > *data)
> >  {
> >     dev_set_drvdata(dev, data);
> >  }
> > +
> > +const char *rust_helper_dev_name(const struct device *dev)
> 
> Please add the __rust_helper annotation.

Should I add it to all of the functions in this file?  None of the existing 
functions have
"__rust_helper".

> 
> > +
> > +    /// Returns the name of the device.
> > +    ///
> > +    /// This is the kobject name of the device, or its initial name if the 
> > kobject is not
> > yet
> > +    /// available.
> > +    ///
> > +    /// For PCI devices, the name in the format "DDDD:BB:DD.F" where:
> 
> This is driver core code, please drop any details for PCI. Also, the subject 
> of
> the patch seems wrong.

Ok.

Reply via email to