On Tue Feb 10, 2026 at 3:45 AM CET, John Hubbard wrote: > Keep Gsp::new() from getting too cluttered, by factoring out the > selection of .fwsignature* items. This will continue to grow as we add > GPUs. > > Reviewed-by: Gary Guo <[email protected]> > Signed-off-by: John Hubbard <[email protected]> > --- > drivers/gpu/nova-core/firmware/gsp.rs | 60 ++++++++++++++------------- > 1 file changed, 31 insertions(+), 29 deletions(-) > > diff --git a/drivers/gpu/nova-core/firmware/gsp.rs > b/drivers/gpu/nova-core/firmware/gsp.rs > index bc2243450989..10761716ed93 100644 > --- a/drivers/gpu/nova-core/firmware/gsp.rs > +++ b/drivers/gpu/nova-core/firmware/gsp.rs > @@ -146,6 +146,36 @@ pub(crate) struct GspFirmware { > } > > impl GspFirmware { > + fn get_gsp_sigs_section(chipset: Chipset) -> Option<&'static str> {
Please don't use the 'get' prefix, as it commonly indicates taking a reference count. Let's use something like find_gsp_sigs_section().
