A few simple, loosely-related small improvements for nova-core, including reporting unprocessed data in GSP messages, removal of unnecessary code in GSP and the sequencer, and leveraging the Zeroable derive macro and core library's CStr. Probably nothing too controversial, so I plan on applying it soon after -rc1 gets released.
This revision is based on master. Signed-off-by: Alexandre Courbot <[email protected]> --- Changes in v3: - Use inspect() to warn about remaining data in the GSP command queue. - Drop "firmware: fwsec: do not require bound device when unneeded". - Drop "simplify str_from_null_terminated" as `str_from_null_terminated` has been removed. - Derive `Zeroable` on the original `GspStaticConfigInfo` tuple struct. - Link to v2: https://patch.msgid.link/[email protected] Changes in v2: - Rebase on drm-rust-next. - Add a patch to reuse previously acquired reference to define in GSP boot sequence. - Link to v1: https://patch.msgid.link/[email protected] --- Alexandre Courbot (8): gpu: nova-core: gsp: warn if data remains after processing a message gpu: nova-core: gsp: remove unnecessary Display impls gpu: nova-core: gsp: simplify sequencer opcode parsing gpu: nova-core: gsp: remove unneeded sequencer trait gpu: nova-core: gsp: derive `Debug` on more sequencer types gpu: nova-core: gsp: derive Zeroable for GspStaticConfigInfo gpu: nova-core: use core library's CStr instead of kernel one gpu: nova-core: gsp: use available device reference drivers/gpu/nova-core/firmware.rs | 2 +- drivers/gpu/nova-core/firmware/gsp.rs | 6 +- drivers/gpu/nova-core/gsp/boot.rs | 34 +++------- drivers/gpu/nova-core/gsp/cmdq.rs | 14 ++++- drivers/gpu/nova-core/gsp/fw.rs | 104 +++---------------------------- drivers/gpu/nova-core/gsp/fw/commands.rs | 5 +- drivers/gpu/nova-core/gsp/sequencer.rs | 18 +++--- drivers/gpu/nova-core/nova_core.rs | 2 +- 8 files changed, 45 insertions(+), 140 deletions(-) --- base-commit: 9702969978695d9a699a1f34771580cdbb153b33 change-id: 20251208-nova-misc-1d797b5d64f2 Best regards, -- Alexandre Courbot <[email protected]>
