On Fri, Sep 28, 2007 at 12:09:20PM +0200, Tim Blechmann wrote: > hi phil, > > i just had a look at your changes ... to me, they look really good and i > would like to merge them into the trunk ... > > a few things, that i came across: > - i preferred the old inlet snapping behavior (snap to the nearest inlet > in the specific object) in stead of the behavior you implemented (snap > to the nearest inlet). there are two use cases, where this is quite > confusing (see klingt.org/~tim/snapping1.png and snapping2.png). in both > cases, the mouse courser is inside the |list set 1| object. in the first > case, no snapping occurs, and in the second case, it snaps to the lower > object (i marked the mouse position with a red dot) > - using colors for marking selected objects is not a bad idea, but using > red is a bit too strong for my eyes ... also, i am using the color red > to mark objects, that couldn't be created by the engine (see > klingt.org/~tim/selected_uninitialized.png) > - hovered xlets highlight the connections, even in the run mode ... > - there is my old bug, which i already solved in the trunk > (http://klingt.org/~tim/connection_drawing_problem.png) > > > Again the branch is at > > <http://unununium.org/~indigo/nova/pretty-gui-connections/> I can send a > > patch too, if anyone wants one. > > is there an easy way to create a diff between a bazaar and a subversion > repository? > if not it would be great if you could send me a diff against the > subversion trunk ... > > cheers, tim .... and thanks a lot for your work!
I've updated the branch with changes to address these issues: - connections will snap to any nearby inlet only if the cursor is not in a different object than the inlet. I think this addresses your point, and mine, which was that if the cursor is over the xlet but not the object, it won't snap. It also extends the snapping region to 15 pixels away from the inlet in all directions, which I think is less confusing for pd nonusers. - the colors have been changed to be much more subdued. The selection color was actually orange, not red. Maybe you need a better monitor? :) Anyway, selection color is the indigo that was previously used for connections, and connections are now normally gray but highlight indigo on hover. I think there will be more time to twiddle colors later, so let's not get too hung up on this. - connection hover highlighting now happens only in edit mode. The easiest way to merge the branch is probably to use bzr-svn (http://bazaar-vcs.org/BzrForeignBranches/Subversion; it's also available in ubuntu) to make a checkout of svn trunk, then use "bzr merge" and "bzr ci" to commit to subversion. I think if it's done this way, some metadata that would otherwise be lost is not, which makes things easier for me. Another way is to use "bzr bundle". It makes patches with added bzr metadata (which "patch" will ignore). There may be a way to have it not generate the metadata at all too. However if you apply this with patch and "svn commit", then the merge information is lost which makes things hard for me, so I'd prefer the other method. If you apply the bundles with "bzr merge" instead of patch, and use bzr-svn to commit it, then it's no different than if you had merged it with the first method. Mailing these may be a good workflow since it allows people not using bzr to treat it as a plain old patch. The only downside is they can get a little big. For example, the changes so far make a 139 Kb bundle, or 29 Kb compressed. Without bzr metadata, the patch is 21 Kb uncompressed. _______________________________________________ nova-dev mailing list [email protected] http://klingt.org/cgi-bin/mailman/listinfo/nova-dev http://tim.klingt.org/nova
