Unfortunately, the description in the OpenFlow spec doesn't match the reference implementation. The OpenFlow v0.8.9 release notes do match the implementation, though:

        
http://openflowswitch.org/wk/index.php/OpenFlow_0.8.9_release_notes#Modify_Actions_in_Existing_Flow_Entries

The difference is that the spec states that if an OFPFC_MODIFY action doesn't match any entries, then it must be added. The implementation only modifies entries that it can find, it will never add them. According to the spec, KK's code should have worked regardless of which method he used.

My personal opinion is that the reference implementation's behavior makes more sense, but this is a discussion for one of the OpenFlow dev lists.

--Justin


On Feb 15, 2009, at 10:54 PM, Brandon Heller wrote:

Hi KK,

Please see section 4.6 of the spec for the differences.  Available at:

http://www.openflowswitch.org/documents/openflow-spec-v0.8.9.pdf

In short, modify keeps the associated flow counters, while add overwrites them.

-b

On Sun, Feb 15, 2009 at 10:23 PM, kk yap <[email protected]> wrote:
Hi,

I managed to do the flow mod by changing the command the ADD instead
of MODIFY.  Can someone explain what is the difference?

Thanks.

Regards
KK

2009/2/14 Justin Pettit <[email protected]>:
> Can you send us a either a pcap file or a printout of the bytes on the wire?
>
> --Justin
>
>
> On Feb 14, 2009, at 5:31 AM, kk yap wrote:
>
>> Hi,
>>
>> I have sent a ofp_flow_mod message, which I verified to be correctly >> formed using a wireshark to a software reference switch. However, I >> do not see the flow entry when I do a dpctl dump-flows. The entry is >> made to be Permanent (both hard and idle timeout). Can anyone think
>> of a reason why this is so?
>>
>> Thanks in advance.
>>
>> Regards
>> KK
>>
>> _______________________________________________
>> nox-dev mailing list
>> [email protected]
>> http://noxrepo.org/mailman/listinfo/nox-dev_noxrepo.org
>
>

_______________________________________________
nox-dev mailing list
[email protected]
http://noxrepo.org/mailman/listinfo/nox-dev_noxrepo.org



_______________________________________________
nox-dev mailing list
[email protected]
http://noxrepo.org/mailman/listinfo/nox-dev_noxrepo.org

Reply via email to