Woops, I introduced a bug. I was converting 'reason' to host byte order,
but it's only 8 bits. This causes it to always be 0 since it turns into
a short before ntohs(). I attached the fix, sorry about that.
-Derek
On 01/13/2011 02:55 PM, kk yap wrote:
Thanks. I pushed this.
Regards
KK
On 12 January 2011 21:40, Derek Cormier<[email protected]> wrote:
Thanks! I'm glad my patches are decent.
I've attached another one for destiny:
In a Flow_removed_event, the fields are taken from an ofp_flow_removed
message,
but a couple of fields were missing (reason and priority). I added these to
the event
struct and changed python's flow removed callback generator to give these
new parameters.
-Derek
On 01/12/2011 04:43 AM, kk yap wrote:
Hi Derek,
Thanks. Great patches as usual. I have pushed them to the destiny
branch.
Martin and Murphy, I believe I have pushed most (if not all) of
Derek's patches at this moment. If anything else is missing, let me
know.
Thanks.
Regards
KK
On 11 January 2011 07:23, Martin Casado<[email protected]> wrote:
Derek,
Thanks for the patches, these are very helpful. One of us will take a
look
shortly.
.martin
Hello,
Here are two patches for destiny for the Python API.
patch 1:
- in pyrt.cc, add datapath id to the dictionaries created by
Flow_removed_event and Error_event
patch2:
- add lots of doxygen doc strings to core.api
- add callback generators for flow mod and flow removed events
- change the names of callback generators to make them more readable
- add more constants for dictionary keys
-Derek
On 01/04/2011 10:27 AM, kk yap wrote:
Hi Derek,
Thanks. Doxygen comments are presented in the code. E.g.,
/** \brief Event
* Some event
*
* @author ykk
* @date Jan 2011
*/
struct x_event
{
...
}
They are more in-depth example in the components.
Regards
KK
On 3 January 2011 17:19, Derek Cormier<[email protected]>
wrote:
Sure thing. Where do the doxygen comments go? I've never used doxygen
before, I'm assuming they go above the struct definition but I don't see
any
such comments in the files I edited. Is there another file?
Thanks,
-Derek
On 01/04/2011 06:20 AM, kk yap wrote:
Hi Derek,
Sorry it took me a while to get to this. Can you put in doxygen
comments for these patches? The patches includes new structs and so
on from what I can see. Else, I can do it. But I doubt I can get to
it fast enough. Thanks.
Regards
KK
On 27 December 2010 23:23, Derek Cormier<[email protected]>
wrote:
Here's a couple more patches for destiny.
'barrier-reply.tar.gz' - make barrier reply events available to the
Python
API.
'flow-stats-in.tar.gz' - add a convenience method in component to
register
for flow stats in events.
-Derek
On 12/28/2010 01:30 AM, Martin Casado wrote:
Thanks KK. I pushed a few edits as well.
Hi,
I have done that for destiny and pushed the file. Martin, you should
probably check the list again. If I have missed you out (since I only
exploited git log), do let me know.
Regards
KK
_______________________________________________
nox-dev mailing list
[email protected]
http://noxrepo.org/mailman/listinfo/nox-dev_noxrepo.org
_______________________________________________
nox-dev mailing list
[email protected]
http://noxrepo.org/mailman/listinfo/nox-dev_noxrepo.org
--
~~~~~~~~~~~~~~~~~~~~~~~~~~~
Martin Casado
Nicira Networks, Inc.
www.nicira.com | www.openvswitch.org
cell: 650-776-1457
~~~~~~~~~~~~~~~~~~~~~~~~~~~
>From 3578f2c1aa8b0d62bf56198d23d419a4529f86a6 Mon Sep 17 00:00:00 2001
From: Derek Cormier <[email protected]>
Date: Thu, 13 Jan 2011 15:18:57 +0900
Subject: [PATCH 11/11] Fix a bug where the 8-bit reason field in a Flow_removed_event
is being converted to host byte order.
---
src/include/flow-removed.hh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/include/flow-removed.hh b/src/include/flow-removed.hh
index 206c4f5..8a7c81c 100644
--- a/src/include/flow-removed.hh
+++ b/src/include/flow-removed.hh
@@ -100,7 +100,7 @@ Flow_removed_event::Flow_removed_event(datapathid datapath_id_,
datapath_id(datapath_id_)
{
priority = ntohs(ofr->priority);
- reason = ntohs(ofr->reason);
+ reason = ofr->reason;
cookie = ntohll(ofr->cookie);
duration_sec = ntohl(ofr->duration_sec);
duration_nsec = ntohl(ofr->duration_nsec);
--
1.7.0.4
_______________________________________________
nox-dev mailing list
[email protected]
http://noxrepo.org/mailman/listinfo/nox-dev_noxrepo.org
