[ 
https://issues.apache.org/jira/browse/NPANDAY-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188456#comment-13188456
 ] 

Adrián Boimvaser commented on NPANDAY-533:
------------------------------------------

Thanks Brett. I originally did the refactoring before rev 1227173, and then I 
had to redo it. That's why I missed those details. Also, I didn't know how to 
run the integration tests.
                
> Refactor wix-maven-plugin to reduce duplication
> -----------------------------------------------
>
>                 Key: NPANDAY-533
>                 URL: https://issues.apache.org/jira/browse/NPANDAY-533
>             Project: NPanday
>          Issue Type: Improvement
>          Components: Maven Plugins
>    Affects Versions: 1.5.0-incubating
>            Reporter: Adrián Boimvaser
>            Assignee: Brett Porter
>             Fix For: 1.5.0-incubating
>
>         Attachments: wixMavenPluginRefactored.patch
>
>
> I refactored the wix-maven-plugin to:
> * Reduce some duplication
> * Take advantage of the enhanced for loop
> * Simplify the control flow in cases where: if (condition) { throw ... } else 
> { ... }
>   can be better expressed as: if (condition) { throw ... } ...
> I also added a couple configuration options: supressSchemaValidation (-ss) & 
> cultures (-cultures)
> I attach the patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to