[ 
https://issues.apache.org/jira/browse/NPANDAY-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266431#comment-13266431
 ] 

Lars Corneliussen commented on NPANDAY-422:
-------------------------------------------

Should be fixed with NPANDAY-231; we should try to remove NPanday.Plugin to see 
if it works.
                
> [regression introduced by 186] .NET-Plugins can not have custom dependencies
> ----------------------------------------------------------------------------
>
>                 Key: NPANDAY-422
>                 URL: https://issues.apache.org/jira/browse/NPANDAY-422
>             Project: NPanday
>          Issue Type: Improvement
>          Components: Maven Plugins
>    Affects Versions: 1.4-incubating
>            Reporter: Lars Corneliussen
>            Assignee: Lars Corneliussen
>             Fix For: 1.5.0-incubating
>
>
> For 1.3.1 the PAB was removed. Instead, before executing, stuff is moved to 
> reactor's root 'target'-directory.
> But dependencies are not copied along. Onyl NPanday.Plugin is manually copied.
> {code:title=NetExecutableFactoryImpl.java/getNetExecutableFromRepository}
> //TODO: Replace
> String pluginArtifactPath = PathUtil.getPrivateApplicationBaseFileFor(
> artifactContext.getArtifactsFor( "npanday.plugin", "NPanday.Plugin", null, 
> null ).get( 0 ),
> localRepository ).getAbsolutePath();
> {code}
> The place, where files are copied is also quite weird. Documentation and 
> bethod name don't fit at all.
> getPrivateApplicationBaseFileFor runs PathUtil.getDotNetArtifact(), which 
> then copies the file.
> {code:title=PathUtil.getDotNetArtifact(Artifact, String)}
> /**
> * Returns the path of the artifact within the user assembly cache.
> *
> * @param artifact        the artifact to find the path of. This value should 
> not be null.
> * @return the path of the artifact within the user assembly cache or null if 
> either of the specified
> *         parameters is null
> */
> public static File getDotNetArtifact( Artifact artifact, String source )
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to