Hi Brett, ----- Original Message ----- From: "Brett Porter" <[email protected]> To: [email protected] Sent: Tuesday, October 12, 2010 1:41:28 AM Subject: Re: svn commit: r1002923 - in /incubator/npanday/branches/npanday-vs2010-support: ./ components/dotnet-artifact/src/main/java/npanday/artifact/impl/ components/dotnet-artifact/src/main/resources/META-INF/plexus/ components/dotnet-core/src/main/java/npanday...
On 30/09/2010, at 11:43 AM, [email protected] wrote: > Author: apadilla > Date: Thu Sep 30 01:43:08 2010 > New Revision: 1002923 > > URL: http://svn.apache.org/viewvc?rev=1002923&view=rev > Log: > * added patch submitted by crimmc for VS 2010 support > * revised vsinstaller plugin to enable auto generation of addin file in VS2010 > * revised addin in template/NPanday.VisualStudio.Addin so that addin file > will be available in VS 2010 Addin Manager General comment: it's always good to isolate formatting changes from actual changes, so they are easier to read :) Likewise, it's good to separate things like debugging additions into separate revisions. Ok, noted. One more thing: > > @@ -305,6 +309,9 @@ > <operatingSystem>Windows</operatingSystem> > </platform> > <platform> > + <operatingSystem>Windows 7</operatingSystem> > + </platform> > + <platform> > <operatingSystem>Mac OS X</operatingSystem> > </platform> > <platform> > @@ -360,6 +367,9 @@ > <platforms> > <platform> > <operatingSystem>Windows</operatingSystem> > + </platform> > + <platform> > + <operatingSystem>Windows 7</operatingSystem> > </platform> > <platform> > <operatingSystem>Mac OS X</operatingSystem> > @@ -434,6 +444,9 @@ > <operatingSystem>Windows</operatingSystem> > </platform> > <platform> > + <operatingSystem>Windows 7</operatingSystem> > + </platform> > + <platform> > <operatingSystem>Mac OS X</operatingSystem> > </platform> > <platform> > @@ -490,6 +503,9 @@ > <operatingSystem>Windows</operatingSystem> > </platform> > <platform> > + <operatingSystem>Windows 7</operatingSystem> > + </platform> > + <platform> > <operatingSystem>Mac OS X</operatingSystem> > </platform> > <platform> > @@ -537,6 +553,9 @@ > <operatingSystem>Windows</operatingSystem> > </platform> > <platform> > + <operatingSystem>Windows 7</operatingSystem> > + </platform> > + <platform> > <operatingSystem>Mac OS X</operatingSystem> > </platform> > <platform> Do these need to be different? I thought Windows was a catch all for different Windows versions. I've double checked and yes, Windows catch all different Windows versions. I'll remove this config. - Brett -- Brett Porter [email protected] http://brettporter.wordpress.com/ Thanks, liit
