On Thu, Apr 7, 2011 at 4:02 PM, Adelita Padilla <[email protected]> wrote:
> Hi Everyone,
>
>
> I'd like to solicit ideas/comments/suggestions for my proposal for
> NPanday-397 -> https://issues.apache.org/jira/browse/NPANDAY-397
>
>
> The problem here is, if NUnit.Framework is a dependency of the project,
> after generating the pom, "maven-test-plugin" configuration is included in
> the pom file even if there's no project selected in the Project Unit Test
> window.
>
> The current behavior is that, after you click on 'Generate POM' button,
> NPanday already generates the pom file (internally).  After generating, the
> Project Unit Test window is displayed. Then after user clicks on the 'OK'
> button, then the "Successful generating of POMs.." window is displayed.
>
> So basically, your selection on the Project Unit Test window is not used
> because the pom was already generated.
>
> So my proposal for the fix is that, instead of generating the pom file after
> 'Generate POM' button is clicked, I'll first display the Project Unit Test
> window, so that I could get the list of selected projects that will be used
> as unit tests, then after clicking the 'OK' button, the pom file will be
> generated.
>
> So from:
>
> Generate POM button click > generate POM files > display Project NUnit
> Tests window
>
> it will be:
>
> Generate POM button click > display Project NUnit Tests window > Passed the
> selected projects > generate POM files and include maven-test-plugin if
> selected
>
>
> The external behavior is still the same.
>

Sounds good to me..

Thanks,
Deng

Reply via email to