-- Message sent from mobile device
Am 25.04.2011 um 04:29 schrieb Brett Porter <[email protected]>: > > On 23/04/2011, at 11:36 PM, Adelita Padilla wrote: > >> Hi Brett, >> >>>> >>>> /** >>>> + * @parameter expression ="${npanday.settings}" >>>> + */ >>>> + private String settingsPath; >>>> + >>> >>> Above, npanday.settings refers to a file. Here, it refers to a path. I >>> think you should change this to private File settingsFile and adjust >>> accordingly. >>> >>> >> >> The variable in registry-config.xml is not really needed because the value >> will be based on the ${npanday.settings} configured in the mojo and if >> there's no configuration the default-value (which is ${user.home}/.m2) will >> be used. > > I think that property can still be confusing - I'd expect it to be a file, > not a path. What do others think? > > - Brett +1 on settingsFolder or refactor to settingsFile. settingsPath can be both, but since settings are expected to be in one, not multiple files, I'd also expect it to be a file path > > -- > Brett Porter > [email protected] > http://brettporter.wordpress.com/ > http://au.linkedin.com/in/brettporter > > > >
