I wasn't inclined to change existing behaviour, just explain any silent failures. I thought this was going away shortly?
- Brett On 20/12/2011, at 6:33 PM, Lars Corneliussen wrote: > Also an error reading the current file should just be thrown; it is an error > that the user has to fix. most certainly he edited it himself. NPanday should > then just fail. > > _ > Mobil versendet. > > Am 20.12.2011 um 05:06 schrieb [email protected]: > >> Author: brett >> Date: Tue Dec 20 04:06:05 2011 >> New Revision: 1221092 >> >> URL: http://svn.apache.org/viewvc?rev=1221092&view=rev >> Log: >> show more information for settings generator, so there's less confusion when >> it is skipped >> >> Modified: >> >> incubator/npanday/trunk/plugins/netplugins/NPanday.Plugin.Settings/javabinding/src/main/java/NPanday/Plugin/Settings/SettingsGeneratorMojo.java >> >> Modified: >> incubator/npanday/trunk/plugins/netplugins/NPanday.Plugin.Settings/javabinding/src/main/java/NPanday/Plugin/Settings/SettingsGeneratorMojo.java >> URL: >> http://svn.apache.org/viewvc/incubator/npanday/trunk/plugins/netplugins/NPanday.Plugin.Settings/javabinding/src/main/java/NPanday/Plugin/Settings/SettingsGeneratorMojo.java?rev=1221092&r1=1221091&r2=1221092&view=diff >> ============================================================================== >> --- >> incubator/npanday/trunk/plugins/netplugins/NPanday.Plugin.Settings/javabinding/src/main/java/NPanday/Plugin/Settings/SettingsGeneratorMojo.java >> (original) >> +++ >> incubator/npanday/trunk/plugins/netplugins/NPanday.Plugin.Settings/javabinding/src/main/java/NPanday/Plugin/Settings/SettingsGeneratorMojo.java >> Tue Dec 20 04:06:05 2011 >> @@ -157,6 +157,7 @@ public class SettingsGeneratorMojo >> { >> if ( !System.getProperty( "os.name" ).contains( "Windows" ) ) >> { >> + getLog().info( "NPANDAY-119-001: Skipping settings generation, >> only valid on Windows operating systems" ); >> return false; >> } >> >> @@ -175,11 +176,13 @@ public class SettingsGeneratorMojo >> { >> if ( isFrameworkVersionExisting( frameworkVersion ) ) >> { >> + getLog().info( "NPANDAY-119-002: Skipping settings >> generation, requested framework " + frameworkVersion + " is already >> configured" ); >> return false; >> } >> } >> catch ( IOException e ) >> { >> + getLog().info( "NPANDAY-119-003: Skipping settings >> generation, error reading existing file: " + e.getLocalizedMessage() ); >> return false; >> } >> } >> >> -- Brett Porter [email protected] http://brettporter.wordpress.com/ http://au.linkedin.com/in/brettporter http://twitter.com/brettporter
